Conditional block executed in the context of serializer method#119
Merged
Conditional block executed in the context of serializer method#119
Conversation
| alias attribute attributes | ||
|
|
||
| def has_one(key, serializer:, **options, &block) # rubocop:disable Naming/PredicateName | ||
| def has_one(key, serializer:, **options, &block) # rubocop:disable Naming/PredicatePrefix |
There was a problem hiding this comment.
Pourquoi cette modification sur le nom de la cop qui est disable?
Collaborator
Author
There was a problem hiding this comment.
Le Gemfile.lock est pas commit dans ce project (c'est une pratique qui existe avec les gem qui est discutable, perso j'aime pas)
Puisque le Gemfile.lock est pas commit, le CI install toujours la dernière version de Rubocop, et une certaine version à modifier le nom de la cop.
IsaBella-Marchand
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the proc passed to the conditional option to call an instance method of the serializer.
Before the
add_name?in the proc could not use theadd_name?defined in the serializer.With this change it can.