Params, if not passed, it is an empty Hash#121
Merged
Conversation
Bhacaz
changed the title
IsaBella-Marchand
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of the
paramsoption in the serializer by ensuring it defaults to an empty hash when not provided, preventing potential errors when accessing keys. The associated tests have been updated to reflect this change and to verify correct behavior whenparamsis omitted.Serializer parameter handling improvements:
lib/bright_serializer/serializer.rb: Changed the initialization of@paramsto default to an empty hash if not provided, ensuring safe access to keys likeparams[:suffix].Test updates for parameter handling:
spec/bright_serializer/serializer_params_spec.rb: Updated attribute blocks and helper methods to accessparams[:suffix]instead of the entireparamsobject, and changed test setup to pass{ suffix: param }asparams.spec/bright_serializer/serializer_params_spec.rb: Added a new context and test to ensure that whenparamsis not passed, it defaults to an empty hash and does not raise errors.