Conversation
IsaBella-Marchand
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to modernize the codebase and improve CI/CD workflows. The main changes include upgrading Ruby and Rails dependencies, enhancing the GitHub Actions setup to support multiple Ruby versions and add Rubocop linting, and updating gem dependencies for better compatibility and functionality.
CI/CD Workflow Improvements:
ubuntu-24.04, updatedactions/checkoutto v4, and replaced the build step with RSpec execution. Added a separate Rubocop job for linting on Ruby 3.4. (.github/workflows/main.yml)Dependency and Compatibility Updates:
actionmailerandrailtiesversion 7.0 or higher, replacing the previousrailsdependency. (gravity_mailbox.gemspec) [1] [2]Gemfilefor broader compatibility and functionality, includingbase64,bigdecimal,concurrent-ruby,drb,mutex_m, andnet-http.Linting and Testing Enhancements:
.rubocop.ymlto use thepluginskey instead ofrequirefor Rubocop configuration, improving compatibility with newer Rubocop versions.rubocop:disable RSpec/Rails/InferredSpecType) from the mailbox controller spec for cleaner test code. (spec/controllers/gravity_mailbox/mailbox_controller_spec.rb)