Change naming for some methods and update some metadata sent

peter-rr · Nov 17, 2023 · b29205b · b29205b
1 parent cbee47f
commit b29205b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/recorder.ts b/src/recorder.ts
@@ -16,11 +16,11 @@ export class Recorder {
     this.record(new Metric(name, MetricType.Gauge, value, metadata));
   }
 
-  async recordActionExecution(actionName: string, metadata: MetricMetadata = {}) {
+  async recordActionExecuted(actionName: string, metadata: MetricMetadata = {}) {
     metadata['action'] = actionName;
     this.record(new Metric('action.executed', MetricType.Counter, 1, metadata));
   }
-  async recordActionInvoke(actionName: string, metadata: MetricMetadata = {}) {
+  async recordActionInvoked(actionName: string, metadata: MetricMetadata = {}) {
     metadata['action'] = actionName;
     this.record(new Metric('action.invoked', MetricType.Counter, 1, metadata));
   }

diff --git a/test/recorder.spec.ts b/test/recorder.spec.ts
@@ -51,22 +51,22 @@ describe('Recorder', function() {
     expect(recorderMetricsSpy[0]).toEqual(expectedMetric);
   });
 
-  it('recordActionExecution()', async function() {
+  it('recordActionExecuted()', async function() {
     const recorderMetricsSpy = [];
     const recorder = new Recorder('test', new testSink(), recorderMetricsSpy);
     const expectedMetric = new Metric('test.action.executed', MetricType.Counter, 1, { action: 'validate', success: true });
 
-    await recorder.recordActionExecution('validate', { success: true });
+    await recorder.recordActionExecuted('validate', { success: true });
     expect(recorderMetricsSpy).toHaveLength(1);
     expect(recorderMetricsSpy[0]).toEqual(expectedMetric);
   });
 
-  it('recordActionInvoke()', async function() {
+  it('recordActionInvoked()', async function() {
     const recorderMetricsSpy = [];
     const recorder = new Recorder('test', new testSink(), recorderMetricsSpy);
-    const expectedMetric = new Metric('test.action.invoked', MetricType.Counter, 1, { action: 'convert', success: true });
+    const expectedMetric = new Metric('test.action.invoked', MetricType.Counter, 1, { action: 'convert' });
 
-    await recorder.recordActionInvoke('convert', { success: true });
+    await recorder.recordActionInvoked('convert');
     expect(recorderMetricsSpy).toHaveLength(1);
     expect(recorderMetricsSpy[0]).toEqual(expectedMetric);
   });
@@ -78,7 +78,7 @@ describe('Recorder', function() {
     const {recorder, stop} = WithPeriodicFlushRecorder(new Recorder('test', sink, recorderMetricsSpy), 100);
     const expectedMetric = new Metric('test.action.executed', MetricType.Counter, 1, { action: 'validate', success: true });
 
-    await recorder.recordActionExecution('validate', { success: true });
+    await recorder.recordActionExecuted('validate', { success: true });
     expect(recorderMetricsSpy).toHaveLength(1);
     expect(recorderMetricsSpy[0]).toEqual(expectedMetric);