Open
Conversation
The old version sample rate is using sample rate of the autocorrelogram to convert the spiking times to samples. I think it should be (spiking time * sample rate of ephys). Besides, I reckon shuffle one time to determine the percentile is not as reliable as 10 times shuffling. The results seem reasonable
MingzeDou
changed the title
Collaborator
|
Hi Mingze That's a good idea, but some of these functions belong in CellExplorer. Otherwise, we risk duplicating the same functions and diverging them, such as loadSession, loadSpikes, and loadOptitrack. It's more complicated as to if open ephys files should be included in CellExplorer. We could remove them, but they help import other data formats into the CellExplorer format. I believe it's time to reorganize the files in CellExplorer into subfolders and consider what files should be moved out. Perhaps we can discuss this with others in the lab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi peter,
I created a new folder for preprocessing in our lab so we don't have to stuff everything in the cellExplorer project as that's not the main focus of cell explorer I think. Also, I think this way makes code sharing clearer and easier