Lidarr API client definition #718
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADRFranklin
requested changes
Jul 14, 2022
pkg/api/src/infra/arr/lidarr.ts
Outdated
| } | ||
| } | ||
|
|
||
| export const GetRadarrInstanceFromDb = async ( |
There was a problem hiding this comment.
You forgot to rename the function from Radarr to Lidarr
| // }, | ||
| // ], | ||
| // response: ArtistsSchema, | ||
| // }, |
There was a problem hiding this comment.
Commented out code, shouldn't make it in to the codebase
|
I should also mention that we follow a strict commit message structure, and that is conventional commits. I'm surprised you were able to commit at all without husky or commit-cli complaining. |
|
I made the necessary adjustments:
|
|
The commit messages still does not follow conventional commits. https://www.conventionalcommits.org/en/v1.0.0/ An example would be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the first step towards Music integration into Petio.
EDIT:
The following PR is a work in progress. Its final goal is music integration into Petio. Here are tentative tasks (i.e., subject to being edited):