Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.approvaltests:approvaltests from 21.1.0 to 22.0.0 #85

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 13, 2023

Bumps com.approvaltests:approvaltests from 21.1.0 to 22.0.0.

Release notes

Sourced from com.approvaltests:approvaltests's releases.

Remove deprecated api

Minor breaking changes

Issue #376 made javax.mail optional Removed deprecated api in JupiterApprovals Moved TestUtils.displayEmail to EmailOpener.displayEmail

Easy reordering of JSON for consistent approvals

The Problem:

JSON does not define an order to the fields.
This can make approving JSON inconsistent as ApprovalTests requires consistent results.

The Solution:

JsonApprovals.verifyJson(json) now has an overload:
JsonApprovals.verifyJson(json, reorderJson: true)
which will alphabetically sort the JSON in the result. By default it still does not reorder the JSON.

Extras

You can call the reordering directly with
JsonUtils.reorderFields(json)
This fixes #422

Commits
  • 0cb7624 . e Add javax.mail to approvaltests-tests
  • 59f9eab a reformat code
  • 14cc240 . t Corrected test that was using deprecated api
  • 9286f5c ! F Separating Email opener and removing deprecated function
  • fc5d790 d updated markdown snippets
  • 265a484 ! F Added reorder field option to JsonApprovals.verifyJson
  • 3636eba ! F JsonUtils.reorderFields
  • c61f422 a reformat code
  • 37e24b7 F - Extend list of known text file extensions
  • 813522a v 21.1.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.approvaltests:approvaltests](https://github.com/approvals/ApprovalTests.Java) from 21.1.0 to 22.0.0.
- [Release notes](https://github.com/approvals/ApprovalTests.Java/releases)
- [Commits](approvals/ApprovalTests.Java@21.1.0...22.0.0)

---
updated-dependencies:
- dependency-name: com.approvaltests:approvaltests
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 13, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ee0f729) 91.34% compared to head (bbad343) 91.34%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #85   +/-   ##
=========================================
  Coverage     91.34%   91.34%           
  Complexity      198      198           
=========================================
  Files            23       23           
  Lines           393      393           
  Branches         43       43           
=========================================
  Hits            359      359           
  Misses           20       20           
  Partials         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfichtner pfichtner merged commit 45ad14c into main Oct 13, 2023
7 checks passed
@dependabot dependabot bot deleted the dependabot/maven/com.approvaltests-approvaltests-22.0.0 branch October 13, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants