Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support inverted rules #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: support inverted rules #115

wants to merge 1 commit into from

Conversation

genofire
Copy link
Contributor

@genofire genofire commented Jan 30, 2024 •
edited
Loading

We use this already for 5 month, daily.

@genofire
Copy link
Contributor Author

The last try looks like a problem inside your testsetup / ci pipeline.
I am correct @opoplawski ?

@opoplawski
Copy link
Contributor

Looks like the github ubuntu-latest image is broken. I've reverted to ubuntu-20.04. Please rebase on master.

@opoplawski
Copy link
Contributor

I guess I don't see the need - we already support a ! prefix to invert the rule source or destination.

@genofire
Copy link
Contributor Author

Maybe you are right, I have to check it.
I believe here are some more inverted flags, maybe we should remove that eigther

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genofire @opoplawski