Fix release builds for musl targets #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `libpg_query.a` static archive fails to link during a release build for musl targets with errors like: "undefined reference to `_longjmp_chk'". This appears to be caused by the fact that the static archive is compiled with the default toolchain, and so has references to symbols provided by glibc (but not musl libc). This change switches to use the `musl-gcc` wrapper as `CC` when the target triple ends with `-musl`.
|
Seems reasonable - @msepga @seanlinsley any concerns with adding that? |
lfittl
reviewed
Dec 23, 2023
| @@ -39,6 +39,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
|
|
|||
| make.env_remove("PROFILE").arg("-C").arg(&out_dir).arg("build"); | |||
|
|
|||
| if env::var("TARGET").unwrap().ends_with("-musl") { | |||
| make.env("CC", "musl-gcc"); | |||
There was a problem hiding this comment.
Could we change this so it respects CC if set in the environment? (i.e. only hardcode CC to musl-gcc if CC is not set, and we're on a target ending in -musl)
(per separate discussion with @msepga, who is better versed at Rust than I am 😄)
|
@JamesGuthrie As an alternate approach to special casing musl, I'm curious if changing to the If you could give #39 a try, that changes to using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libpg_query.astatic archive fails to link during a release build for musl targets with errors like: "undefined reference to `_longjmp_chk'".This appears to be caused by the fact that the static archive is compiled with the default toolchain, and so has references to symbols provided by glibc (but not musl libc).
This change switches to use the
musl-gccwrapper asCCwhen the target triple ends with-musl.