Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimp codeexamples (issue #640) part 2 (of pull request #711) #729

Closed
wants to merge 2 commits into from
Closed

Pimp codeexamples (issue #640) part 2 (of pull request #711) #729

wants to merge 2 commits into from

Conversation

Mo-Gul
Copy link
Contributor

@Mo-Gul Mo-Gul commented Aug 18, 2019

basically this is the continuation of pull request #711, but it doesn't show up there, because I first merged branch PimpCodeexamples into master.

@hmenke
Copy link
Member

hmenke commented Aug 18, 2019

Does this replace #711 or is it in addition?

@hmenke
Copy link
Member

hmenke commented Aug 18, 2019

BTW, the commit 4dd4ac8 was the one that screwed everything up.

@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Aug 19, 2019

Regarding the code this seems to be a replacement, but of course the conversation continues here, if you still have something ...

I had to create a new Pull Request, because this time I first merged PimpCodeexamples into (my) master and thus the newest commit didn't show up in pull request #711. (This is in line with the text shown near the end at that pull request

Add more commits by pushing to the PimpCodeexamples branch on Mo-Gul/pgf.

@hmenke
Copy link
Member

hmenke commented Aug 20, 2019

I will probably merge this PR step-by-step because I really want to avoid merging 4dd4ac8. That will just screw up the history again, like this did fcba572...9d5755f (which caused #694).

@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Aug 21, 2019

As you wish. That is why I asked you (several times) to do the merge in my fork, but after I didn't hear anything from you, I gave it a try myself ...

As also already written via email, I have added you as a collaborator in my fork, so if you can fix the mess there ... You decide what is less work for you.

hmenke pushed a commit to hmenke/pgf that referenced this pull request Aug 27, 2019
@hmenke
Copy link
Member

hmenke commented Aug 27, 2019

I have rebase your master onto the upstream master and removed the broken stuff, so it will never show up in the git history. I've opened #733 for that. Could you please review it, to make sure that I haven't accidentally dropped any of your changes?

Mo-Gul added a commit that referenced this pull request Aug 27, 2019
Improved version of #729 without questionable commits
@hmenke
Copy link
Member

hmenke commented Aug 27, 2019

As I wrote previously, I have rebased this branch onto master, so it is not longer mergable. Please reset this branch to origin/master and continue from there. To do so, follow these steps:

# Add the upstream source as a remote repository to git
git remote add upstream https://github.com/pgf-tikz/pgf.git
# Fetch the latest pgf-tikz/master branch
git fetch upstream master
# Rename your current master branch into oldmaster
git branch -m master oldmaster
# Check out the pgf-tikz/master branch under the name master
git checkout -B master upstream/master
# Cherry pick the two new commits you made on oldmaster to the current master
git cherry-pick 329e374 1a5d61d
# Force push to the remote because the refs have changed
git push --force origin master

Mo-Gul added 2 commits August 28, 2019 06:20
- harmonized spelling of `i.e.` and `e.g.`
- corrected line breaking in `pgfmanual-en-math-numberprinting.tex` where a |...| was split across lines
@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Aug 28, 2019

Done. Many thanks for the instructions.

Please keep in mind that I am not a professional in git, thus, e.g. I don't have a clue what "rebasing" or a "cherry-pick" is. But of course I am willing to learn, so keep going with instructions ;)

@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Sep 1, 2019

Can't this pull request simply be closed? Because all new commits are not related to issue #640 any more ...

@hmenke
Copy link
Member

hmenke commented Sep 1, 2019

It's up to you. You could also just change the title and I delete the obsolete comments.

@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Sep 2, 2019

Then we'll close it. Changing the title may cause some confusion because this issue is referenced elsewhere (I guess).

The real pull request with these changes was done by Henry in pull request #733.

@Mo-Gul Mo-Gul closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants