-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pimp codeexamples (issue #640) part 2 (of pull request #711) #729
Conversation
Does this replace #711 or is it in addition? |
BTW, the commit 4dd4ac8 was the one that screwed everything up. |
Regarding the code this seems to be a replacement, but of course the conversation continues here, if you still have something ... I had to create a new Pull Request, because this time I first merged
|
I will probably merge this PR step-by-step because I really want to avoid merging 4dd4ac8. That will just screw up the history again, like this did fcba572...9d5755f (which caused #694). |
As you wish. That is why I asked you (several times) to do the merge in my fork, but after I didn't hear anything from you, I gave it a try myself ... As also already written via email, I have added you as a collaborator in my fork, so if you can fix the mess there ... You decide what is less work for you. |
I have rebase your |
Improved version of #729 without questionable commits
As I wrote previously, I have rebased this branch onto master, so it is not longer mergable. Please reset this branch to # Add the upstream source as a remote repository to git
git remote add upstream https://github.com/pgf-tikz/pgf.git
# Fetch the latest pgf-tikz/master branch
git fetch upstream master
# Rename your current master branch into oldmaster
git branch -m master oldmaster
# Check out the pgf-tikz/master branch under the name master
git checkout -B master upstream/master
# Cherry pick the two new commits you made on oldmaster to the current master
git cherry-pick 329e374 1a5d61d
# Force push to the remote because the refs have changed
git push --force origin master |
- harmonized spelling of `i.e.` and `e.g.` - corrected line breaking in `pgfmanual-en-math-numberprinting.tex` where a |...| was split across lines
Done. Many thanks for the instructions. Please keep in mind that I am not a professional in git, thus, e.g. I don't have a clue what "rebasing" or a "cherry-pick" is. But of course I am willing to learn, so keep going with instructions ;) |
Can't this pull request simply be closed? Because all new commits are not related to issue #640 any more ... |
It's up to you. You could also just change the title and I delete the obsolete comments. |
Then we'll close it. Changing the title may cause some confusion because this issue is referenced elsewhere (I guess). The real pull request with these changes was done by Henry in pull request #733. |
basically this is the continuation of pull request #711, but it doesn't show up there, because I first merged branch
PimpCodeexamples
intomaster
.