Skip to content

Commit

Permalink
Variable substitution fix
Browse files Browse the repository at this point in the history
  • Loading branch information
shayonj committed Nov 3, 2024
1 parent 6288dce commit b1c0102
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-and-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ jobs:
build-args: |
VERSION=${{ github.ref_name }}
COMMIT=${{ github.sha }}
DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')
DATE=${{ format('2006-01-02T15:04:05Z') }}
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ ARG VERSION=dev
ARG COMMIT=none
ARG DATE=unknown
RUN CGO_ENABLED=0 GOOS=linux go build -v \
-ldflags '-s -w \
-X "github.com/shayonj/pg_flo/cmd.version=${VERSION}" \
-X "github.com/shayonj/pg_flo/cmd.commit=${COMMIT}" \
-X "github.com/shayonj/pg_flo/cmd.date=${DATE}"' \
-ldflags "-s -w \
-X 'github.com/shayonj/pg_flo/cmd.version=${VERSION}' \
-X 'github.com/shayonj/pg_flo/cmd.commit=${COMMIT}' \
-X 'github.com/shayonj/pg_flo/cmd.date=${DATE}'" \
-o pg_flo .

FROM alpine:latest
Expand Down
10 changes: 7 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,12 @@ For a complete list of configuration options, see our [example configuration fil
Here's a minimal example to get started:

```shell
# Start NATS server
# Start NATS server with JetStream configuration
docker run -d --name pg_flo_nats \
--network host \
nats:latest
-v /path/to/nats-server.conf:/etc/nats/nats-server.conf \
nats:latest \
-c /etc/nats/nats-server.conf

# Start replicator with config file
docker run -d --name pg_flo_replicator \
Expand Down Expand Up @@ -114,7 +116,9 @@ docker run -d --name pg_flo_worker \
> - pg_flo needs network access to both PostgreSQL and NATS
> - The examples above use `--network host` for local development
> - For production, we recommend using proper container networking (Docker networks, Kubernetes, etc.)
> - See our [example configuration](internal/pg-flo.yaml) for all available options
> - NATS server must be configured with JetStream enabled and appropriate message size limits
> - See our [example configuration](internal/pg-flo.yaml) for all available options for setting up pg_flo
> - See our [example NATS configuration](internal/nats-server.conf) for NATS server settings
### Example Configuration File

Expand Down

0 comments on commit b1c0102

Please sign in to comment.