Skip to content

Conversation

jumski
Copy link
Contributor

@jumski jumski commented Sep 17, 2025

This PR implements output aggregation for map steps, completing the critical functionality needed for map steps to pass their results to dependent steps.

What this adds:

  • Aggregates outputs from all map step tasks into a single array when the step completes
  • Preserves task_index ordering in the aggregated output array
  • Handles edge cases including empty maps (0 tasks) and NULL outputs from individual tasks
  • Optimizes map-to-map data flow to avoid unnecessary aggregation/decomposition cycles
  • Ensures dependent steps receive properly aggregated arrays from completed map steps

Context:

Map steps spawn N tasks to process array elements in parallel. This PR ensures their outputs are properly combined back into an array for consumption by downstream steps, completing the map
step infrastructure in the SQL core layer.

Copy link

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 8ec0268

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 09-17-add-map-step-output-aggregation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

nx-cloud bot commented Sep 17, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 8ec0268

Command Status Duration Result
nx affected -t lint typecheck test --parallel -... ❌ Failed 6m 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-05 19:28:30 UTC

@jumski jumski changed the title chore: update PLAN.md with current feature and task statuses feat: add Map Step Output Aggregation Sep 17, 2025
@jumski jumski marked this pull request as ready for review September 17, 2025 07:12
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from 1cc39ef to 93cd2af Compare September 17, 2025 10:54
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from 93cd2af to a61429b Compare September 17, 2025 12:07
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from a61429b to b01eb63 Compare September 17, 2025 13:10
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch 3 times, most recently from 5a0ef17 to 9ab5b0e Compare September 17, 2025 19:16
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from d02a76c to a3647dc Compare September 17, 2025 19:35
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from a3647dc to 290913f Compare September 17, 2025 20:15
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch 2 times, most recently from e6b99ed to b77f743 Compare September 18, 2025 04:35
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from b77f743 to 2b1f97e Compare September 18, 2025 07:32
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch 2 times, most recently from fcb8222 to 7422f2a Compare September 18, 2025 08:46
Copy link
Contributor

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-217.pgflow.pages.dev

📝 Details:

  • Branch: 09-17-add-map-step-output-aggregation
  • Commit: 49044803ef5e56eb40d9250564be324f06b46eea
  • View Logs

_Last updated: _

Copy link
Contributor

🔍 Preview Deployment: Playground

Deployment successful!

🔗 Preview URL: https://pr-217--pgflow-demo.netlify.app

📝 Details:

  • Branch: 09-17-add-map-step-output-aggregation
  • Commit: 49044803ef5e56eb40d9250564be324f06b46eea
  • View Logs

_Last updated: _

Reflects ongoing work on map step output aggregation, related migration, testing,
and documentation efforts, along with current implementation status and pending
tasks for map step support in the project.
@jumski jumski force-pushed the 09-17-add-map-step-output-aggregation branch from c1c4c34 to 8ec0268 Compare October 5, 2025 19:20
@jumski jumski force-pushed the 09-16-handle-arrays-in-start-tasks branch from 53ca34b to 99d14b5 Compare October 5, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant