Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of PostgreSQL table functions that use the newer RETURN clause syntax (introduced in PostgreSQL 14) instead of the traditional AS $$ ... $$ block syntax. The fix addresses issue #103 by updating SQL queries to use pg_get_function_sqlbody() and modifying code generation logic to detect and properly format functions with RETURN clauses.
- Updates SQL queries to use
pg_get_function_sqlbody()with fallback toprosrcfor extracting function definitions - Adds logic to detect and handle
RETURNclause syntax in function/procedure SQL generation - Includes test case for table function using
RETURNclause withSETOF timestamptz
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ir/queries/queries.sql | Added COALESCE with pg_get_function_sqlbody() to properly extract function bodies that use RETURN clause syntax |
| ir/queries/queries.sql.go | Generated code reflecting SQL query changes for function/procedure retrieval |
| internal/diff/function.go | Added conditional logic to detect RETURN clause syntax and format it without dollar quoting |
| internal/diff/procedure.go | Added same RETURN clause detection logic for procedures |
| testdata/diff/create_function/add_function/. | Test data files demonstrating the fix with a new table function using RETURN clause |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9eff4bb to
3b8431d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #101