Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates test cases for SQL view creation and formatting by merging multiple test scenarios into a single comprehensive test suite. The changes eliminate redundant test cases while preserving coverage for array operators, text search functions, and view formatting.
- Removed duplicate test cases for
add_view_coalesceandadd_view_array_operators - Merged test coverage into the main
add_viewtest case - Updated SQL formatting logic to consistently use custom formatter and handle indentation
- Fixed whitespace normalization in tests to preserve indentation
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/diff/create_view/add_view_coalesce/* | Removed entire test case directory (all files deleted) |
| testdata/diff/create_view/add_view_array_operators/* | Removed entire test case directory (all files deleted) |
| testdata/diff/create_view/add_view/old.sql | Merged table schema with additional columns to support consolidated tests |
| testdata/diff/create_view/add_view/new.sql | Merged view definitions for array operators and text search into single test |
| testdata/diff/create_view/add_view/diff.sql | Updated expected diff output with merged view definitions |
| testdata/diff/create_view/alter_view/diff.sql | Fixed formatting to place SELECT on same line as view name |
| testdata/diff/create_materialized_view/*/diff.sql | Simplified WHERE clause formatting (removed explicit type casts) |
| ir/normalize.go | Removed conditional logic for custom formatter, now always uses it |
| ir/formatter.go | Fixed SELECT formatting to place first column on same line; added DISTINCT support |
| internal/diff/diff_test.go | Fixed SQL normalization to preserve indentation while trimming trailing whitespace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
36111d4 to
b79fedc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.