Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test case for validating NULLIF, GREATEST, and LEAST SQL functions, specifically targeting issue #103 related to divide-by-zero scenarios. The test case verifies that the schema diff tool correctly handles views containing these functions.
Key Changes:
- Added a new view
nullif_functions_viewdemonstrating NULLIF usage for divide-by-zero protection - Includes test coverage for GREATEST, LEAST, and complex CASE expressions with NULLIF
- Updated test plan files to reflect the addition of the new view
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/diff/create_view/add_view/plan.txt | Updated expected plan output to include the new nullif_functions_view |
| testdata/diff/create_view/add_view/plan.sql | Added SQL DDL for the new view to the expected plan SQL |
| testdata/diff/create_view/add_view/plan.json | Added JSON representation of the create operation for the new view |
| testdata/diff/create_view/add_view/new.sql | Added the source SQL definition for nullif_functions_view with comprehensive comments |
| testdata/diff/create_view/add_view/diff.sql | Added the new view to the expected diff output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate #103