Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the index inspection logic by eliminating SQL parsing dependencies. The changes move from parsing index definitions using pg_query_go to directly extracting index column information from PostgreSQL's system catalogs.
Key Changes:
- Replaced complex AST-based index definition parsing with direct SQL queries to
pg_get_indexdefandindoptionarray - Removed dependency on
github.com/pganalyze/pg_query_go/v6 - Deleted ~250 lines of parsing helper functions that are no longer needed
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ir/queries/queries.sql | Extended index query to directly extract column names, positions, and sort directions using PostgreSQL system functions |
| ir/queries/queries.sql.go | Generated code adding new fields (NumColumns, ColumnDefinitions, ColumnDirections) to GetIndexesForSchemaRow struct |
| ir/inspector.go | Removed pg_query dependency and replaced parseIndexDefinition with direct iteration over query results; deleted all AST extraction helper functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.