chore: add dump test case to verify index sorted order#135
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive test case to verify that database indexes are dumped in alphabetical order rather than their creation order, addressing GitHub issue #133. This ensures consistent and predictable output from the pgschema dump command.
- Adds test data files for the
issue_133_index_sorttest case - Includes integration test for the new test case
- Validates alphabetical ordering of indexes in dump output
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/dump/issue_133_index_sort/raw.sql | Defines test schema with indexes created in non-alphabetical order to validate sorting behavior |
| testdata/dump/issue_133_index_sort/pgschema.sql | Expected output from pgschema showing indexes sorted alphabetically |
| testdata/dump/issue_133_index_sort/pgdump.sql | Reference output from pg_dump showing indexes in alphabetical order |
| testdata/dump/issue_133_index_sort/manifest.json | Test metadata describing the purpose and expectations of the test case |
| cmd/dump/dump_integration_test.go | Adds integration test function to execute the new test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify #133