Skip to content

fix: properly drop temporary NOT NULL constraint #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianzhou merged 2 commits into from
Nov 23, 2025
Merged

fix: properly drop temporary NOT NULL constraint #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51c727e
🐛 Fix adding new NOT NULL constraint
sam-mosleh Nov 18, 2025
c97394f
✅ Update add_not_null test
sam-mosleh Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/plan/rewrite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,10 @@ func generateColumnNotNullRewrite(_ *diff.ColumnDiff, path string) []RewriteStep
setNotNullSQL := fmt.Sprintf("ALTER TABLE %s ALTER COLUMN %s SET NOT NULL;",
tableName, column)

// Step 4: Drop CHECK constraint
dropConstraintSQL := fmt.Sprintf("ALTER TABLE %s DROP CONSTRAINT %s;",
tableName, ir.QuoteIdentifier(constraintName))

return []RewriteStep{
{
SQL: addConstraintSQL,
Expand All @@ -306,6 +310,10 @@ func generateColumnNotNullRewrite(_ *diff.ColumnDiff, path string) []RewriteStep
SQL: setNotNullSQL,
CanRunInTransaction: true,
},
{
SQL: dropConstraintSQL,
CanRunInTransaction: true,
},
}
}

Expand Down
6 changes: 6 additions & 0 deletions testdata/diff/online/add_not_null/plan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@
"type": "table.column",
"operation": "alter",
"path": "public.users.email"
},
{
"sql": "ALTER TABLE users DROP CONSTRAINT email_not_null;",
"type": "table.column",
"operation": "alter",
"path": "public.users.email"
}
]
}
Expand Down
2 changes: 2 additions & 0 deletions testdata/diff/online/add_not_null/plan.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ ALTER TABLE users ADD CONSTRAINT email_not_null CHECK (email IS NOT NULL) NOT VA
ALTER TABLE users VALIDATE CONSTRAINT email_not_null;

ALTER TABLE users ALTER COLUMN email SET NOT NULL;

ALTER TABLE users DROP CONSTRAINT email_not_null;
2 changes: 2 additions & 0 deletions testdata/diff/online/add_not_null/plan.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ ALTER TABLE users ADD CONSTRAINT email_not_null CHECK (email IS NOT NULL) NOT VA
ALTER TABLE users VALIDATE CONSTRAINT email_not_null;

ALTER TABLE users ALTER COLUMN email SET NOT NULL;

ALTER TABLE users DROP CONSTRAINT email_not_null;
Loading