Add limit to missing "smart-quote" Keywords#177
Merged
tianzhou merged 1 commit intopgplex:mainfrom Nov 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds "limit" to the list of SQL reserved words that require smart quoting when used as identifiers. The change ensures that column or variable names matching the SQL "limit" keyword are properly quoted to avoid syntax errors.
- Adds "limit" to the
reservedWordsmap - Adds test cases to verify that "limit" is correctly identified as requiring quotes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ir/quote.go | Adds "limit" to the reservedWords map to mark it as requiring quotes |
| ir/quote_test.go | Adds test cases for the "limit" keyword in both NeedsQuoting and QuoteIdentifier tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adam-Mustafa
force-pushed
the
add-limit-to-quote-list
branch
from
00aedb9 to
64a244a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
limitto the list of "smart-quote" keywords that render column/variable names with a quote.Note: Will be adding more as a follow-up (#178)