Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive test case to reproduce and verify the fix for GitHub issue #183, which concerns the handling of generated column expressions during schema dumps. The test validates that complex expressions in GENERATED ALWAYS AS clauses are correctly preserved.
- Adds test data files demonstrating three scenarios: boolean expressions with type casting, string concatenation with TRIM, and tsvector generation with COALESCE
- Implements an integration test following the established test pattern
- Includes detailed documentation explaining the test scenarios
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/dump/issue_183_generated_column/raw.sql | Defines the raw SQL schema with three test cases for generated columns, including detailed comments explaining each scenario |
| testdata/dump/issue_183_generated_column/pgschema.sql | Expected pgschema output showing normalized generated column expressions (redundant type casts removed) |
| testdata/dump/issue_183_generated_column/pgdump.sql | Reference pg_dump output for comparison, confirming PostgreSQL's normalization of the expressions |
| testdata/dump/issue_183_generated_column/manifest.json | Test metadata describing the purpose and scenarios covered by this test case |
| cmd/dump/dump_integration_test.go | Adds the test function following the established pattern for integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to reproduce #183