Skip to content

Comments

feat: release darwin/amd64 binaries#199

Merged
tianzhou merged 1 commit intopgplex:mainfrom
alecthomas:main
Dec 18, 2025
Merged

feat: release darwin/amd64 binaries#199
tianzhou merged 1 commit intopgplex:mainfrom
alecthomas:main

Conversation

@alecthomas
Copy link
Contributor

Note that this doesn't modify the Homebrew formula.

Also note that I have no real means of testing this!

Fixes #198

Copilot AI review requested due to automatic review settings December 11, 2025 04:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds darwin/amd64 (macOS Intel) binary releases to the GitHub Actions release workflow by consolidating the build process into a single cross-compilation job that handles both Linux and macOS binaries for AMD64 and ARM64 architectures.

Key Changes:

  • Unified the Linux and macOS binary builds into a single matrix-based job using Go's cross-compilation capabilities
  • Added darwin/amd64 to the build matrix alongside existing linux/amd64, linux/arm64, and darwin/arm64 targets
  • Removed the separate build-macos job that previously handled only darwin/arm64 native builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Note that this doesn't modify the Homebrew formula.
Copy link
Contributor

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's take a spin

@tianzhou tianzhou merged commit 0cd8fab into pgplex:main Dec 18, 2025
1 check passed
@alecthomas
Copy link
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: darwin/amd64 releases

2 participants