fix: add SearchPath comparison to functionsEqualExceptAttributes#235
Merged
tianzhou merged 1 commit intopgplex:mainfrom Jan 6, 2026
Merged
Conversation
The functionsEqualExceptAttributes() function was missing a SearchPath field comparison. This caused SET search_path changes to be detected but silently dropped — no DDL was generated. The other two comparison functions (functionsEqual and functionsEqualExceptComment) correctly compare SearchPath. This fix aligns functionsEqualExceptAttributes with them. Added test case to alter_function_attributes to verify SearchPath changes generate CREATE OR REPLACE FUNCTION statements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alecthomas
pushed a commit
to alecthomas/pgschema
that referenced
this pull request
Jan 26, 2026
…lex#235) The functionsEqualExceptAttributes() function was missing a SearchPath field comparison. This caused SET search_path changes to be detected but silently dropped — no DDL was generated. The other two comparison functions (functionsEqual and functionsEqualExceptComment) correctly compare SearchPath. This fix aligns functionsEqualExceptAttributes with them. Added test case to alter_function_attributes to verify SearchPath changes generate CREATE OR REPLACE FUNCTION statements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SET search_pathchanges were detected but silently dropped (no DDL generated)SearchPathfield comparison tofunctionsEqualExceptAttributes()ininternal/diff/function.goalter_function_attributestest case to cover SearchPath changesRoot Cause
The
functionsEqualExceptAttributes()function was missing aSearchPathcomparison, while the other two comparison functions (functionsEqualandfunctionsEqualExceptComment) correctly compared it. This caused the function to incorrectly returntruewhen only SearchPath differed, entering the attribute-only branch which only handlesParallelandIsLeakproof.Test plan
alter_function_attributestest casePGSCHEMA_TEST_FILTER="create_function/alter_function_attributes" go test -v ./internal/diff -run TestDiffFromFilesPGSCHEMA_TEST_FILTER="create_function/alter_function_attributes" go test -v ./cmd -run TestPlanAndApply🤖 Generated with Claude Code