refactor: review ir module to enhance code readability#237
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the IR module to enhance code readability by extracting inline maps, constants, and duplicate logic into well-documented, reusable components.
Changes:
- Extracted type mapping dictionaries and constants to package-level for better maintainability and performance
- Eliminated duplicate logic between Function and Procedure argument handling
- Replaced inconsistent string conversion calls with the existing
safeInterfaceToStringhelper
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ir/normalize.go | Extracted postgresTypeNormalization map from function to package-level variable |
| ir/ir.go | Deduplicated Function/Procedure argument extraction logic into shared helper functions |
| ir/inspector.go | Extracted constants for trigger types and sequence max values, oidToTypeName map, and sequence max value helper; standardized string conversions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alecthomas
pushed a commit
to alecthomas/pgschema
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.