Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes procedure and function visibility issues by changing the SQL queries to use p.prosrc instead of r.routine_definition from the information schema. This addresses cases where routine_definition returns NULL for procedures/functions owned by restricted roles, while p.prosrc provides reliable access to the source code.
Key changes:
- Updated SQL queries to use
pg_proc.prosrcinstead ofinformation_schema.routines.routine_definition - Changed Go struct field types from
interface{}tostringfor routine definitions - Removed permission validation logic that was causing errors when
routine_definitionwas NULL - Updated tests to verify that procedure/function source is accessible via the new approach
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/queries/queries.sql | Updated SQL queries to use p.prosrc AS routine_definition instead of r.routine_definition |
| internal/queries/queries.sql.go | Generated code reflecting SQL changes and type updates from interface{} to string |
| internal/queries/models.sql.go | Updated sqlc version from v1.29.0 to v1.30.0 |
| internal/queries/dml.sql.go | Updated sqlc version from v1.29.0 to v1.30.0 |
| internal/ir/inspector.go | Removed permission validation logic and simplified routine definition handling |
| cmd/dump/dump_permission_integration_test.go | Replaced permission error tests with tests verifying source code accessibility via p.prosrc |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #34