Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes environment variable handling for PGHOST and PGPORT by consolidating dotenv functionality into PreRun functions rather than flag defaults.
- Refactored environment variable handling to use PreRun functions instead of flag defaults
- Created new PreRun function variants to handle optional connection parameters (host, port, app name)
- Added comprehensive tests for the environment variable utility functions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/util/env.go | Added new PreRun function variants to handle host, port, and app name environment variables |
| cmd/util/env_test.go | Added comprehensive test coverage for environment variable utility functions |
| cmd/dump/dump.go | Updated to use new PreRun function and removed env defaults from flag definitions |
| cmd/plan/plan.go | Updated to use new PreRun function and removed env defaults from flag definitions |
| cmd/apply/apply.go | Updated to use new PreRun function with app name support and removed env defaults from flag definitions |
| cmd/dump/dump_test.go | Removed duplicate test functions that are now covered in the util package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // PreRunEWithEnvVars creates a PreRunE function that validates required database connection parameters | ||
| // It checks environment variables if the corresponding flags weren't explicitly set | ||
| func PreRunEWithEnvVars(dbPtr, userPtr *string) func(*cobra.Command, []string) error { | ||
| return PreRunEWithEnvVarsAndConnection(dbPtr, userPtr, nil, nil) |
There was a problem hiding this comment.
[nitpick] Consider using a more explicit approach by creating a struct to hold the optional parameters instead of passing multiple nil values. This would make the function calls clearer and reduce the risk of passing parameters in the wrong order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #40