Skip to content

feat: VIEW where NOT NULL#57

Merged
tianzhou merged 1 commit intomainfrom
view_where_not_null
Oct 8, 2025
Merged

feat: VIEW where NOT NULL#57
tianzhou merged 1 commit intomainfrom
view_where_not_null

Conversation

@tianzhou
Copy link
Contributor

@tianzhou tianzhou commented Oct 8, 2025

Fix #54

Copilot AI review requested due to automatic review settings October 8, 2025 15:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for "IS NOT NULL" (and "IS NULL") expressions in view definitions by implementing proper parsing and comparison functionality for NULL test operations.

  • Adds formatNullTest function to handle NULL test expression formatting in the PostgreSQL formatter
  • Extends compareExpressions to support NULL test comparisons with a new compareNullTests function
  • Updates test data to demonstrate the new functionality with a view containing "IS NOT NULL" conditions

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

File Description
ir/formatter.go Adds NULL test expression formatting support with formatNullTest function
internal/diff/view.go Implements NULL test comparison logic with compareNullTests function
testdata/diff/create_view/add_view/. Updated test data files to demonstrate NULL test functionality in views

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tianzhou tianzhou merged commit 3843d79 into main Oct 8, 2025
1 check passed
@tianzhou tianzhou deleted the view_where_not_null branch October 23, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: where clause showing up with actual conditions empty

2 participants