Skip to content

Comments

chore: correct MATERIALIZED VIEW TYPE#69

Merged
tianzhou merged 1 commit intomainfrom
materialized_view
Oct 11, 2025
Merged

chore: correct MATERIALIZED VIEW TYPE#69
tianzhou merged 1 commit intomainfrom
materialized_view

Conversation

@tianzhou
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 11, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the display type for materialized views in PostgreSQL schema dump comments from "VIEW" to "MATERIALIZED VIEW" and updates the pgschema version references in test files.

  • Updates the formatObjectCommentHeader function to properly detect and label materialized views
  • Updates version references from pgschema 1.0.3 to 1.2.1 in test data files
  • Fixes comment headers to correctly identify materialized views as "MATERIALIZED VIEW" type

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/dump/formatter.go Adds special handling logic to correctly identify and label materialized views in comment headers
testdata/dump/sakila/pgschema.sql Updates comment header to correctly label rental_by_category as MATERIALIZED VIEW type
testdata/dump/tenant/pgschema.sql Updates pgschema version reference from 1.0.3 to 1.2.1
testdata/dump/employee/pgschema.sql Updates pgschema version reference from 1.0.3 to 1.2.1
testdata/dump/bytebase/pgschema.sql Updates pgschema version reference from 1.0.3 to 1.2.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tianzhou tianzhou merged commit be408a3 into main Oct 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant