Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the display type for materialized views in PostgreSQL schema dump comments from "VIEW" to "MATERIALIZED VIEW" and updates the pgschema version references in test files.
- Updates the
formatObjectCommentHeaderfunction to properly detect and label materialized views - Updates version references from pgschema 1.0.3 to 1.2.1 in test data files
- Fixes comment headers to correctly identify materialized views as "MATERIALIZED VIEW" type
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/dump/formatter.go | Adds special handling logic to correctly identify and label materialized views in comment headers |
| testdata/dump/sakila/pgschema.sql | Updates comment header to correctly label rental_by_category as MATERIALIZED VIEW type |
| testdata/dump/tenant/pgschema.sql | Updates pgschema version reference from 1.0.3 to 1.2.1 |
| testdata/dump/employee/pgschema.sql | Updates pgschema version reference from 1.0.3 to 1.2.1 |
| testdata/dump/bytebase/pgschema.sql | Updates pgschema version reference from 1.0.3 to 1.2.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.