Skip to content

feat: split materialized view from view #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianzhou merged 1 commit into from
Oct 12, 2025
Merged

feat: split materialized view from view #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions internal/diff/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ const (
DiffTypeTableIndexComment
DiffTypeView
DiffTypeViewComment
DiffTypeViewIndex
DiffTypeViewIndexComment
DiffTypeMaterializedView
DiffTypeMaterializedViewComment
DiffTypeMaterializedViewIndex
DiffTypeMaterializedViewIndexComment
DiffTypeFunction
DiffTypeProcedure
DiffTypeSequence
Expand Down Expand Up @@ -62,10 +64,14 @@ func (d DiffType) String() string {
return "view"
case DiffTypeViewComment:
return "view.comment"
case DiffTypeViewIndex:
return "view.index"
case DiffTypeViewIndexComment:
return "view.index.comment"
case DiffTypeMaterializedView:
return "materialized_view"
case DiffTypeMaterializedViewComment:
return "materialized_view.comment"
case DiffTypeMaterializedViewIndex:
return "materialized_view.index"
case DiffTypeMaterializedViewIndexComment:
return "materialized_view.index.comment"
case DiffTypeFunction:
return "function"
case DiffTypeProcedure:
Expand Down Expand Up @@ -120,10 +126,14 @@ func (d *DiffType) UnmarshalJSON(data []byte) error {
*d = DiffTypeView
case "view.comment":
*d = DiffTypeViewComment
case "view.index":
*d = DiffTypeViewIndex
case "view.index.comment":
*d = DiffTypeViewIndexComment
case "materialized_view":
*d = DiffTypeMaterializedView
case "materialized_view.comment":
*d = DiffTypeMaterializedViewComment
case "materialized_view.index":
*d = DiffTypeMaterializedViewIndex
case "materialized_view.index.comment":
*d = DiffTypeMaterializedViewIndexComment
case "function":
*d = DiffTypeFunction
case "procedure":
Expand Down
5 changes: 0 additions & 5 deletions internal/diff/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ func generateCreateIndexesSQL(indexes []*ir.Index, targetSchema string, collecto
generateCreateIndexesSQLWithType(indexes, targetSchema, collector, DiffTypeTableIndex, DiffTypeTableIndexComment)
}

// generateCreateViewIndexesSQL generates CREATE INDEX statements for materialized view indexes
func generateCreateViewIndexesSQL(indexes []*ir.Index, targetSchema string, collector *diffCollector) {
generateCreateIndexesSQLWithType(indexes, targetSchema, collector, DiffTypeViewIndex, DiffTypeViewIndexComment)
}

// generateCreateIndexesSQLWithType generates CREATE INDEX statements with specified diff types
func generateCreateIndexesSQLWithType(indexes []*ir.Index, targetSchema string, collector *diffCollector, indexType DiffType, commentType DiffType) {
// Sort indexes by name for consistent ordering
Expand Down
138 changes: 91 additions & 47 deletions internal/diff/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,15 @@ func generateCreateViewsSQL(views []*ir.View, targetSchema string, collector *di
// If compare mode, CREATE OR REPLACE, otherwise CREATE
sql := generateViewSQL(view, targetSchema)

// Determine the diff type based on whether it's materialized
diffType := DiffTypeView
if view.Materialized {
diffType = DiffTypeMaterializedView
}

// Create context for this statement
context := &diffContext{
Type: DiffTypeView,
Type: diffType,
Operation: DiffOperationCreate,
Path: fmt.Sprintf("%s.%s", view.Schema, view.Name),
Source: view,
Expand All @@ -30,18 +36,35 @@ func generateCreateViewsSQL(views []*ir.View, targetSchema string, collector *di
// Add view comment
if view.Comment != "" {
viewName := qualifyEntityName(view.Schema, view.Name, targetSchema)
sql := fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(view.Comment))
commentType := DiffTypeViewComment
if view.Materialized {
commentType = DiffTypeMaterializedViewComment
sql := fmt.Sprintf("COMMENT ON MATERIALIZED VIEW %s IS %s;", viewName, quoteString(view.Comment))

// Create context for this statement
context := &diffContext{
Type: DiffTypeViewComment,
Operation: DiffOperationCreate,
Path: fmt.Sprintf("%s.%s", view.Schema, view.Name),
Source: view,
CanRunInTransaction: true,
}
// Create context for this statement
context := &diffContext{
Type: commentType,
Operation: DiffOperationCreate,
Path: fmt.Sprintf("%s.%s", view.Schema, view.Name),
Source: view,
CanRunInTransaction: true,
}

collector.collect(context, sql)
collector.collect(context, sql)
} else {
sql := fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(view.Comment))

// Create context for this statement
context := &diffContext{
Type: commentType,
Operation: DiffOperationCreate,
Path: fmt.Sprintf("%s.%s", view.Schema, view.Name),
Source: view,
CanRunInTransaction: true,
}

collector.collect(context, sql)
}
}

// For materialized views, create indexes
Expand All @@ -50,8 +73,8 @@ func generateCreateViewsSQL(views []*ir.View, targetSchema string, collector *di
for _, index := range view.Indexes {
indexList = append(indexList, index)
}
// Generate index SQL for materialized view indexes
generateCreateViewIndexesSQL(indexList, targetSchema, collector)
// Generate index SQL for materialized view indexes - use MaterializedView types
generateCreateIndexesSQLWithType(indexList, targetSchema, collector, DiffTypeMaterializedViewIndex, DiffTypeMaterializedViewIndexComment)
}
}
}
Expand Down Expand Up @@ -80,7 +103,7 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d

// Use DiffOperationAlter to categorize as a modification
context := &diffContext{
Type: DiffTypeView,
Type: DiffTypeMaterializedView,
Operation: DiffOperationAlter,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff,
Expand All @@ -90,9 +113,9 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d

// Add view comment if present
if diff.New.Comment != "" {
sql := fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(diff.New.Comment))
sql := fmt.Sprintf("COMMENT ON MATERIALIZED VIEW %s IS %s;", viewName, quoteString(diff.New.Comment))
commentContext := &diffContext{
Type: DiffTypeViewComment,
Type: DiffTypeMaterializedViewComment,
Operation: DiffOperationCreate,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff.New,
Expand All @@ -107,7 +130,7 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d
for _, index := range diff.New.Indexes {
indexList = append(indexList, index)
}
generateCreateViewIndexesSQL(indexList, targetSchema, collector)
generateCreateIndexesSQLWithType(indexList, targetSchema, collector, DiffTypeMaterializedViewIndex, DiffTypeMaterializedViewIndexComment)
}

continue // Skip the normal processing for this view
Expand All @@ -126,33 +149,36 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d
// Only generate COMMENT ON VIEW statement if comment actually changed
if diff.CommentChanged {
viewName := qualifyEntityName(diff.New.Schema, diff.New.Name, targetSchema)
if diff.NewComment == "" {
sql := fmt.Sprintf("COMMENT ON VIEW %s IS NULL;", viewName)

// Create context for this statement
context := &diffContext{
Type: DiffTypeView,
Operation: DiffOperationAlter,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff,
CanRunInTransaction: true,
}

collector.collect(context, sql)
// Determine the diff type and SQL based on whether it's materialized
var sql string
var diffType DiffType
if diff.New.Materialized {
diffType = DiffTypeMaterializedView
if diff.NewComment == "" {
sql = fmt.Sprintf("COMMENT ON MATERIALIZED VIEW %s IS NULL;", viewName)
} else {
sql = fmt.Sprintf("COMMENT ON MATERIALIZED VIEW %s IS %s;", viewName, quoteString(diff.NewComment))
}
} else {
sql := fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(diff.NewComment))

// Create context for this statement
context := &diffContext{
Type: DiffTypeView,
Operation: DiffOperationAlter,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff,
CanRunInTransaction: true,
diffType = DiffTypeView
if diff.NewComment == "" {
sql = fmt.Sprintf("COMMENT ON VIEW %s IS NULL;", viewName)
} else {
sql = fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(diff.NewComment))
}
}

collector.collect(context, sql)
// Create context for this statement
context := &diffContext{
Type: diffType,
Operation: DiffOperationAlter,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff,
CanRunInTransaction: true,
}

collector.collect(context, sql)
}

// For materialized views, handle index modifications (only if indexes actually changed)
Expand All @@ -162,18 +188,24 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d
diff.AddedIndexes,
diff.ModifiedIndexes,
targetSchema,
DiffTypeViewIndex,
DiffTypeViewIndexComment,
DiffTypeMaterializedViewIndex,
DiffTypeMaterializedViewIndexComment,
collector,
)
}
} else {
// Create the new view (CREATE OR REPLACE works for regular views, materialized views are handled by drop/create cycle)
sql := generateViewSQL(diff.New, targetSchema)

// Determine diff type based on whether it's materialized
diffType := DiffTypeView
if diff.New.Materialized {
diffType = DiffTypeMaterializedView
}

// Create context for this statement
context := &diffContext{
Type: DiffTypeView,
Type: diffType,
Operation: DiffOperationAlter,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff,
Expand All @@ -185,18 +217,27 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d
// Add view comment for recreated views
if diff.New.Comment != "" {
viewName := qualifyEntityName(diff.New.Schema, diff.New.Name, targetSchema)
sql := fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(diff.New.Comment))
var commentSQL string
var commentType DiffType

if diff.New.Materialized {
commentSQL = fmt.Sprintf("COMMENT ON MATERIALIZED VIEW %s IS %s;", viewName, quoteString(diff.New.Comment))
commentType = DiffTypeMaterializedViewComment
} else {
commentSQL = fmt.Sprintf("COMMENT ON VIEW %s IS %s;", viewName, quoteString(diff.New.Comment))
commentType = DiffTypeViewComment
}

// Create context for this statement
context := &diffContext{
Type: DiffTypeComment,
Type: commentType,
Operation: DiffOperationCreate,
Path: fmt.Sprintf("%s.%s", diff.New.Schema, diff.New.Name),
Source: diff.New,
CanRunInTransaction: true,
}

collector.collect(context, sql)
collector.collect(context, commentSQL)
}

// For materialized views that were recreated, recreate indexes
Expand All @@ -205,7 +246,7 @@ func generateModifyViewsSQL(diffs []*viewDiff, targetSchema string, collector *d
for _, index := range diff.New.Indexes {
indexList = append(indexList, index)
}
generateCreateViewIndexesSQL(indexList, targetSchema, collector)
generateCreateIndexesSQLWithType(indexList, targetSchema, collector, DiffTypeMaterializedViewIndex, DiffTypeMaterializedViewIndexComment)
}
}
}
Expand All @@ -218,15 +259,18 @@ func generateDropViewsSQL(views []*ir.View, targetSchema string, collector *diff
for _, view := range views {
viewName := qualifyEntityName(view.Schema, view.Name, targetSchema)
var sql string
var diffType DiffType
if view.Materialized {
sql = fmt.Sprintf("DROP MATERIALIZED VIEW %s RESTRICT;", viewName)
diffType = DiffTypeMaterializedView
} else {
sql = fmt.Sprintf("DROP VIEW IF EXISTS %s CASCADE;", viewName)
diffType = DiffTypeView
}

// Create context for this statement
context := &diffContext{
Type: DiffTypeView,
Type: diffType,
Operation: DiffOperationDrop,
Path: fmt.Sprintf("%s.%s", view.Schema, view.Name),
Source: view,
Expand Down
Loading