Skip to content

Comments

feat: MATERIALIZED VIEW COMMENT#73

Merged
tianzhou merged 1 commit intomainfrom
include_materizlied_view
Oct 12, 2025
Merged

feat: MATERIALIZED VIEW COMMENT#73
tianzhou merged 1 commit intomainfrom
include_materizlied_view

Conversation

@tianzhou
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 12, 2025 13:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for COMMENT statements on materialized views by implementing parser functionality to handle OBJECT_MATVIEW object types and includes test data demonstrating materialized view comments in action.

  • Added parser support for COMMENT ON MATERIALIZED VIEW statements in the parseComment method
  • Created test materialized views with comments and associated indexes
  • Updated test data to include materialized view inclusions and expected schema outputs

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ir/parser.go Implements parsing logic for materialized view comments by handling OBJECT_MATVIEW case
testdata/include/materialized_views/user_order_summary.sql Adds test materialized view with aggregated user statistics and comment
testdata/include/materialized_views/monthly_stats.sql Adds test materialized view with monthly order statistics and comment
testdata/include/main.sql Includes the new materialized view files in the test schema
testdata/include/expected_full_schema.sql Updates expected output to include the materialized views and their comments
Comments suppressed due to low confidence (1)

testdata/include/expected_full_schema.sql:1

  • The COMMENT statement for user_order_summary is missing from the expected schema output. This comment should appear after line 250 to match the source file structure.
-- Main schema file demonstrating \i include functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tianzhou tianzhou force-pushed the include_materizlied_view branch from f18502e to e957acb Compare October 12, 2025 13:06
@tianzhou tianzhou merged commit d5c8902 into main Oct 12, 2025
2 checks passed
@tianzhou tianzhou deleted the include_materizlied_view branch October 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant