Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes index name quotation issues (GitHub issue #80) by ensuring that index names requiring quotation are properly quoted when generating SQL statements. The fix addresses cases where index names contain spaces, special characters, mixed case, or reserved keywords.
- Updates SQL generation code to properly quote index names using
ir.QuoteIdentifier() - Adds comprehensive test coverage with various index naming scenarios
- Ensures compatibility between pgschema output and PostgreSQL's quoting requirements
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
testdata/dump/issue_80_index_name_quote/raw.sql |
Test data with various index naming scenarios requiring quotation |
testdata/dump/issue_80_index_name_quote/pgschema.sql |
Expected pgschema output with properly quoted index names |
testdata/dump/issue_80_index_name_quote/pgdump.sql |
Reference pg_dump output for comparison |
testdata/dump/issue_80_index_name_quote/manifest.json |
Test case metadata and description |
internal/plan/rewrite.go |
Fixed index name quoting in DROP and ALTER INDEX statements |
internal/diff/index.go |
Fixed index name quoting in CREATE INDEX statements |
cmd/dump/dump_integration_test.go |
Added integration test for the index name quotation fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #80