feat: always dump separate constraint with name#85
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces always-named constraint mode for pgschema, fixing issue #83 where explicitly named constraints were being converted to inline syntax during dumping. The change ensures all constraints are dumped as table-level with explicit names, preserving constraint names and improving schema consistency.
Key changes:
- Modified constraint generation to always use named table-level format (e.g.,
CONSTRAINT users_pkey PRIMARY KEY (id)) - Updated both CREATE TABLE and ALTER TABLE statements to use consistent constraint naming
- Added support for preserving complex foreign key attributes (DEFERRABLE, NOT VALID)
Reviewed Changes
Copilot reviewed 129 out of 129 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/diff/table.go | Refactored constraint handling to generate all constraints as table-level with explicit names |
| internal/diff/constraint.go | Updated constraint SQL generation to always include constraint names |
| internal/diff/identifier_quote_test.go | Updated test expectations to match new named constraint format |
| cmd/dump/dump_integration_test.go | Added integration test for issue #83 |
| testdata/dump/issue_83_explicit_constraint_name/* | Added test case data for named constraint preservation |
| Multiple testdata files | Updated expected outputs to reflect new constraint naming format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
60dfc68 to
ae39c14
Compare
tianzhou
added a commit
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #83