Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in handling column default expressions where complex default expressions containing parentheses combined with NOT NULL constraints were being formatted incorrectly (GitHub issue #91). The specific issue was that closing parentheses were being lost before NOT NULL constraints.
Key changes:
- Updated the
normalizeDefaultValuefunction to use regex-based type cast removal that preserves content after the type cast - Added comprehensive test case for the issue including raw SQL, expected pgschema output, and pg_dump output
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ir/normalize.go | Modified type cast stripping logic to use regex pattern matching instead of simple string truncation |
| cmd/dump/dump_integration_test.go | Added integration test for the default expression bug |
| testdata/dump/issue_91_col_default_expr/raw.sql | Test input SQL demonstrating the problematic default expression pattern |
| testdata/dump/issue_91_col_default_expr/pgschema.sql | Expected output showing correct formatting with preserved parentheses |
| testdata/dump/issue_91_col_default_expr/pgdump.sql | Reference pg_dump output for comparison |
| testdata/dump/issue_91_col_default_expr/manifest.json | Test case metadata and documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #91