Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iteration 6-7] v4.0-beta #122

Merged
merged 22 commits into from
Sep 23, 2019
Merged

[Iteration 6-7] v4.0-beta #122

merged 22 commits into from
Sep 23, 2019

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Sep 15, 2019

Issue - #116

@Jeckerson Jeckerson self-assigned this Sep 15, 2019
@Jeckerson Jeckerson changed the title [Iteration 6-7] v4.0-beta [WIP] [Iteration 6-7] v4.0-beta Sep 16, 2019
@Jeckerson Jeckerson changed the title [WIP] [Iteration 6-7] v4.0-beta [Iteration 6-7] v4.0-beta Sep 21, 2019
Copy link
Member

@ruudboon ruudboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Can you only fix Scrutinizer? Let's release the beta after Phalcon 4-RC.1 is in.

@Jeckerson
Copy link
Member Author

@ruudboon Ignore Scrutinizer, as it will be removed. Because its purpose was to send code coverage to codecov.io and it is possible to achieve with Travis.

@Jeckerson
Copy link
Member Author

Issue for codecov created - #123

@Jeckerson Jeckerson merged commit 5d10572 into 4.0.x Sep 23, 2019
@Jeckerson Jeckerson deleted the 4.0.0-beta.2-iteration-6-7 branch September 23, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants