Skip to content

Conversation

@DKelle
Copy link
Collaborator

@DKelle DKelle commented Oct 30, 2025

Summary & Motivation

This PR implements the SDK side changes to support lighthouse instructions in user transactions.

This pr

  1. takes incoming user transactions
  2. if they are solana, and the user has spending limits enabled, request a new augmented transaction from wallet service
  3. resubmits the resulting transaction to wallet service for signing

How I Tested These Changes

In progress.

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run yarn changeset. This will generate a file where you should write a human friendly summary about the changes. Please respect the versioning system - if any interface has been broken, we need to increase the major version.

Did you update the README files?

If the interfaces of affected packages have changed, please ensure their README files are updated to reflect the new APIs and usage patterns.

@DKelle DKelle changed the title WIP: SDK can query for lighthouse transactions feat: SDK can query for lighthouse transactions Nov 4, 2025
jkadamczyk
jkadamczyk previously approved these changes Nov 4, 2025
Copy link
Collaborator

@jkadamczyk jkadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks beautiful now

rafinskipg
rafinskipg previously approved these changes Nov 4, 2025
Copy link
Collaborator

@jkadamczyk jkadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, mostly nits!

rafinskipg
rafinskipg previously approved these changes Nov 17, 2025
…' of github.com:phantom/wallet-sdk into dallas/wp-7650-sdk-should-request-instruction-injection
rafinskipg
rafinskipg previously approved these changes Nov 18, 2025
@rafinskipg rafinskipg enabled auto-merge November 18, 2025 10:02
rafinskipg
rafinskipg previously approved these changes Nov 18, 2025
iamacook
iamacook previously approved these changes Nov 18, 2025
@rafinskipg rafinskipg dismissed stale reviews from iamacook and themself via 30094c0 November 18, 2025 13:08
@rafinskipg rafinskipg merged commit a763d3d into main Nov 18, 2025
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants