-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/update cookie cmp #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fmormahPhantom
wants to merge
9
commits into
master
Choose a base branch
from
feat/update-cookie-cmp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udios/ft-lib into feat/update-cookie-cmp # Conflicts: # src/index.ts
- swapped referrerPolicy on CMP Script
JPedersen
reviewed
Jul 1, 2025
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "@phantomstudios/ft-lib", | |||
| "version": "0.4.1-rc1", | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never used this versioning with release candidates @DhiaPhntm any thoughts what the version should be? Probably best if we strip release candidate from the version but not sure why it's there
- updated window._sp_queue - enqueueCallbacks now firing
- add cmp client as peer dependency - add interceptManageCookiesLinks for specific link listener for new cooke modal
JPedersen
approved these changes
Jul 9, 2025
JPedersen
requested changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: This update is now published (latest v0.5.0-rc15) and deployed to sites as the new Consent solution