Skip to content

Handle GitHub releases with multiple signatures#420

Open
lkrms wants to merge 1 commit intophar-io:masterfrom
lkrms:fix-multiple-signatures
Open

Handle GitHub releases with multiple signatures#420
lkrms wants to merge 1 commit intophar-io:masterfrom
lkrms:fix-multiple-signatures

Conversation

@lkrms
Copy link
Copy Markdown

@lkrms lkrms commented Feb 2, 2024

This fixes phive install doctum, at least, but I'm not sure how common releases with multiple signatures are; it may be worth incorporating the same fix into other repositories?

@theseer theseer self-assigned this Feb 14, 2024
@theseer
Copy link
Copy Markdown
Member

theseer commented Mar 1, 2024

I'll try to incorporate that hopefully next week.

@lkrms
Copy link
Copy Markdown
Author

lkrms commented Mar 1, 2024

Sounds good. Would you like me to replicate the fix for other repositories?

Also, the QA failure looks like the same issue I had getting a test environment working--the version of PHPStan in phive.xml is too old to appear in the first page of GitHub's release endpoint response. Easy fix is to update phive.xml; less easy fix is to incorporate paging into PHIVE's HTTP client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants