Merge pull request #829 from pharmaR/jt-fix_else_cond_bug

Fix ELSE condition bug

.github/workflows/pkgdown.yaml

@@ -26,7 +26,7 @@ jobs:
 
       - uses: r-lib/actions/setup-r@v2
         with:
-          use-public-rspm: true
+          use-public-rspm: false
           r-version: 'renv'
 
       - uses: r-lib/actions/setup-renv@v2

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: riskassessment
 Title: A web app designed to interface with the `riskmetric` package
-Version: 3.1.1.9001
+Version: 3.1.1.9002
 Authors@R: c( 
     person("Aaron", "Clark", role = c("aut", "cre"), email = "clark.aaronchris@gmail.com"),
     person("Jeff", "Thompson", role = c("aut"),  email = "jeff.thompson51317@gmail.com", comment = "Co-Lead"),

NEWS.md

@@ -1,6 +1,7 @@
 # riskassessment (development version)
 
 * Open hyperlinks in a new tab from cards.
+* Fix bug causing app to crash with ELSE condition in rules
 
 # riskassessment 3.1.1
 

R/mod_decision_automation_utils.R

@@ -24,7 +24,8 @@ assign_decisions <- function(rule_list, package, db_name = golem::get_golem_opti
     if (!is.na(decision)) break
     rule <- rule_list[[i]]
 
-    fn <- purrr::possibly(rule$mapper, otherwise = FALSE)
+    if (rlang::is_function(rule$mapper) || rlang::is_formula(rule$mapper))
+      fn <- purrr::possibly(rule$mapper, otherwise = FALSE)
     if (rule$type == "overall_score") {
       decision <- if (fn(get_pkg_info(package)$score)) rule$decision else NA_character_
       log_message <- glue::glue("Decision for the package {package} was assigned {decision} because the risk score returned TRUE for `{rule$condition}`")