Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Dep pkgs not subject to "Include Suggests" toggle #783

Open
aclark02-arcus opened this issue May 31, 2024 · 3 comments
Open

Reverse Dep pkgs not subject to "Include Suggests" toggle #783

aclark02-arcus opened this issue May 31, 2024 · 3 comments

Comments

@aclark02-arcus
Copy link
Collaborator

dplyr selected in control panel: googledrive listed as a reverse dependency of dplyr, as highlighted below. However, when I load googledrive into the db, it doesn't show up in the "Rev Deps available in db" table.

image

That's because dplyr is only a Suggest for googledrive. I don't think googledrive should show up here while the "Include Suggests" toggle is off / FALSE.

image

@jthompson-arcus
Copy link
Collaborator

I agree with you but currently the reverse dependency list is taken directly from riskmetric and is not broken down by dependency type.

@jthompson-arcus
Copy link
Collaborator

In order to further clarify. The reverse dependencies are being supplied to the app by riskmetric. They come as a character vector. In order for us to only show reverse dependencies where the investigated package is being imported (as opposed to merely being suggested), we would have to come up with a process to grab that information ourselves.

Alternatively, we could open a feature request on riskmetric to include this information in that metric.

@aclark02-arcus
Copy link
Collaborator Author

As discussed on 6/18 dev meetup, let's not open a request with riskmetric yet and continue to think about how to best integrate it in the future, if at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants