Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage GHA passing despite failing to calculate #800

Closed
aclark02-arcus opened this issue Jul 3, 2024 · 4 comments · Fixed by #807
Closed

Test coverage GHA passing despite failing to calculate #800

aclark02-arcus opened this issue Jul 3, 2024 · 4 comments · Fixed by #807
Labels
bug Something isn't working

Comments

@aclark02-arcus
Copy link
Collaborator

Latest commit on master:

https://github.com/pharmaR/riskassessment/actions/runs/9761008268/job/26941091990#step:8:18

Originally posted by @aclark02-arcus in #656 (comment)

@aclark02-arcus aclark02-arcus added the bug Something isn't working label Jul 3, 2024
@jthompson-arcus
Copy link
Collaborator

@dgkf do you by chance know how to resolve this issue? I saw that you did some work on {covr} so I wasn't sure if you had more insight. I noticed that {riskmetric} is having the same issue. I tried a different workflow with #807 but it fails with "Not valid tokenless upload" despite (to my knowledge) passing the token.

@dgkf
Copy link

dgkf commented Jul 9, 2024

It looks like it's not a covr issue, but a rate limit imposed by codecov using unauthenticated uploads

[1] "Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1598s."

And it seems that there was a change to the r-lib workflows about 2mo ago that silently ignores codecov upload failures. Our workflows were most recently updated 7mo ago so we don't have these changes, but I think this would just suppress them, not solve them.

You can either deal with the occasional rate-limiting, or add a CODECOV_TOKEN secret to the repo which will automatically be used to do authenticated uploads.

If you log in through GitHub auth at https://app.codecov.io you should see this repo in the dropdown and you can find the token in the "configure" menu next to the repo name.

@jthompson-arcus
Copy link
Collaborator

Thanks for the input. I had found the information about CODECOV_TOKEN but wasn't putting all the pieces together. Looks like we needed to both update our process and utilize the token.

@aclark02-arcus aclark02-arcus linked a pull request Jul 16, 2024 that will close this issue
@aclark02-arcus
Copy link
Collaborator Author

closed with #796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants