Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-coverage workflow #807

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Fix test-coverage workflow #807

merged 4 commits into from
Jul 10, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (583b9ee) to head (67bc4f4).
Report is 62 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #807      +/-   ##
==========================================
+ Coverage   80.78%   81.91%   +1.13%     
==========================================
  Files          36       36              
  Lines        5547     6692    +1145     
==========================================
+ Hits         4481     5482    +1001     
- Misses       1066     1210     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jthompson-arcus
Copy link
Collaborator Author

Closes #800

@jthompson-arcus jthompson-arcus marked this pull request as ready for review July 10, 2024 13:10
@aclark02-arcus
Copy link
Collaborator

aclark02-arcus commented Jul 10, 2024

I plucked this link out of the code coverage GHA output. Is this the number we are looking for? 81.9%

https://app.codecov.io/github/pharmaR/riskassessment/commit/d7bcdf3e7c5dbf8ce95de0068017931497b46d2c

@jthompson-arcus
Copy link
Collaborator Author

I plucked this link out of the code coverage GHA output. Is this the number we are looking for? 81.9%

https://app.codecov.io/github/pharmaR/riskassessment/commit/d7bcdf3e7c5dbf8ce95de0068017931497b46d2c

Not sure exactly what you are asking. Before the GHA wasn't communicating with codecov. That has been repaired now. You should notice above that this PR has a comment from the codecov bot. Those have been missing for a few weeks now.

@jthompson-arcus
Copy link
Collaborator Author

@aclark02-arcus you might find this link helpful: https://app.codecov.io/gh/pharmaR/riskassessment/pulls. Most of the patch coverages are blank because the GHA stopped communicating with codecov.

@aclark02-arcus aclark02-arcus merged commit df1813b into dev Jul 10, 2024
3 checks passed
@jthompson-arcus jthompson-arcus deleted the jt-800-fix_codecov branch July 10, 2024 15:39
@aclark02-arcus aclark02-arcus linked an issue Jul 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test coverage GHA passing despite failing to calculate
3 participants