-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GHAs for DOCX and PDF downloads #717
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #717 +/- ##
==========================================
+ Coverage 77.17% 78.14% +0.96%
==========================================
Files 33 33
Lines 4872 4872
==========================================
+ Hits 3760 3807 +47
+ Misses 1112 1065 -47 ☔ View full report in Codecov by Sentry. |
I have investigated printing the HTML reports to PDF. While some improvements can be made to make the reports nicer to print interactively, I do not think the work to get the reports to work programmatically is worth the effort (at least not in the short term). Efforts would be better suited to determining which LaTeX packages are necessary to be able to print the DOCX and PDF versions of the report and to provide some user feedback if those packages are missing from the environment where the application is running. |
I was able to get the PDF reports to work on the GHAs by installing the |
I think this gives us a path forward to getting the downloads to work in deployments. Hopefully the steps to get the downloads to work on the GHAs will be similar to what will be needed on the deployment servers. The downside is that users will have to get their respective admins to install the necessary dependencies. |
To summarize a discussion with @Jeff-Thompson12 offline:
|
Per discussion today, I am changing the scope of this PR since the changes made benefit our workflow. I will open a new PR to tackle the download issues when the app is deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #702