Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync meter color on HTML reports #728

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Sync meter color on HTML reports #728

merged 3 commits into from
Dec 15, 2023

Conversation

AARON-CLARK
Copy link
Collaborator

@AARON-CLARK AARON-CLARK commented Dec 13, 2023

Closes #727.
Fixed by copying css from app over to html report. Results:

image

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93f80f1) 77.17% compared to head (cf89a8e) 77.17%.
Report is 12 commits behind head on dev.

❗ Current head cf89a8e differs from pull request most recent head 3bcca3b. Consider uploading reports for the commit 3bcca3b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #728   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files          33       33           
  Lines        4872     4872           
=======================================
  Hits         3760     3760           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeff-Thompson12
Copy link
Collaborator

@AARON-CLARK did you want to add a line to NEWS?

@AARON-CLARK
Copy link
Collaborator Author

@Jeff-Thompson12, I guess I have to since it's a bug from a previous release. Pushed a commit.

Copy link
Collaborator

@Jeff-Thompson12 Jeff-Thompson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeff-Thompson12 Jeff-Thompson12 merged commit f8810e2 into dev Dec 15, 2023
3 checks passed
@Jeff-Thompson12 Jeff-Thompson12 deleted the ac-727-meter-color branch December 15, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants