Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package Dependencies to Reports, Part I #734

Merged
merged 61 commits into from
Jan 17, 2024
Merged

Conversation

Robert-Krajcik
Copy link
Contributor

@Robert-Krajcik Robert-Krajcik commented Dec 27, 2023

This is a cleaner implementation of #723, which was left in DRAFT mode
Closes both #651 and #721

@Robert-Krajcik Robert-Krajcik changed the base branch from master to dev December 27, 2023 16:23
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d902f3c) 77.19% compared to head (87c0ba4) 79.33%.

Files Patch % Lines
R/mod_packageDependencies.R 0.00% 9 Missing ⚠️
R/mod_uploadPackage.R 0.00% 2 Missing ⚠️
R/mod_downloadHandler.R 92.85% 1 Missing ⚠️
R/mod_reportPreview.R 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #734      +/-   ##
==========================================
+ Coverage   77.19%   79.33%   +2.13%     
==========================================
  Files          33       33              
  Lines        4964     5018      +54     
==========================================
+ Hits         3832     3981     +149     
+ Misses       1132     1037      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robert-Krajcik Robert-Krajcik marked this pull request as ready for review December 28, 2023 13:03
@Robert-Krajcik
Copy link
Contributor Author

"suggests" will be added in Part II

@Jeff-Thompson12
Copy link
Collaborator

@Robert-Krajcik remind me, what is the suggested way to setup TinyTeX to get the PDF downloads to work?

Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! With the understanding that you'll target #738 next. Thanks @Robert-Krajcik

@AARON-CLARK AARON-CLARK dismissed Jeff-Thompson12’s stale review January 17, 2024 00:49

Some requests fixed and some others will be fixed in part II (#738)

@AARON-CLARK AARON-CLARK merged commit 8e5f638 into dev Jan 17, 2024
3 checks passed
@AARON-CLARK AARON-CLARK deleted the rk-721-pkgdeps_report branch January 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants