Fix bug where Decision Automation header isn't displaying for "less privileged" roles
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-score based rules for the config
|
Hey @jthompson-arcus, if you don't mind looking at this first thing in the morning, that would be great. Then I'll update my |
aclark02-arcus
changed the title
Decision Automation header isn't displaying for certain less privileged rolesDecision Automation header isn't displaying for "less privileged" roles
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first noticed this bug in the webinar demo deployment:
https://rinpharma.shinyapps.io/riskassessment_shinygathering2025
I was logged in with the
reviewerrole, which means I didn't have theauto_decision_adjustprivilege. As a result, I noticed that the "Decision Automation" header and horizontal line was missing from theUpload Packagetab:I checked the "normal" demo deployment, and this wasn't the case for the
reviewerrole, which was odd. The only difference in this deployment's automation rules is that it includes rules based on pkg scores. When I checked the code base, I saw that theauto_decision_initialdepends on the existence of an upper/lower bound-based rule existing, which explained the issue. Thus, I just changed out the conditional to point to the logical value which monitors whether or not any risk rules exist.