-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #64 adding dataset logo #69
Conversation
@sadchla-codes Since the dataset documentation was generated by create_adams_data.R, could you help populate labels in "Datasets" sheet from the spec? I can add |
Sure, I'll work on that |
R/adpp.R
Outdated
@@ -1,4 +1,4 @@ | |||
#' Dataset adpp | |||
#' Analysis Dataset of Pharmacokinetics Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#' Analysis Dataset of Pharmacokinetics Parameters | |
#' Analysis Dataset of Pharmacokinetic Parameters |
@@ -1,4 +1,4 @@ | |||
#' Dataset advs | |||
#' Vital Signs Analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: sometimes you use "Dataset" (ie Vital Signs Analysis Dataset) and sometimes not (Vital Signs Analysis). Wondering if we can choose one approach here? Maybe just always omit? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that omitting it would look much better aesthetically, I'll make that update.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()