-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #95: Import tibble for printing #90
Conversation
Hi @MikeJohnPage - thanks for the PR! We can definitely look to update this. For completeness could you please:
After that is done please let me know and I will be happy to review and approve. |
Opened issue #95 Where would you like me to place the item in |
We have a workflow for that, so no need. It can be placed under |
Okay, done 👍 |
Thanks - unfortunately not quite what I was meaning sorry, I might've been unclear. I think you are missing the development version section? See the version in main right now for comparison. We should add a new "developer notes" section under the development version, with this update. You can merge main into your branch to get the latest NEWS.md as it updated after you started working on this. Thanks! Also pls fix failing spelling check by adding "tibble" to |
I've made the changes you requested 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MikeJohnPage LGTM 😄
Issue
When printing an adam dataset to the console (e.g., by running
pharmasverseadam::adlb
), tibble formatting is dropped unless you load the tibble (or tidyverse) package because tibble is not imported in the package. This PR fixes this by importing tibble ensuring that the adam datasets print correctly, even without loading tibble/tidyverse first.Checklist
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new datasets occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()