Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #95: Import tibble for printing #90

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

MikeJohnPage
Copy link
Contributor

Issue
When printing an adam dataset to the console (e.g., by running pharmasverseadam::adlb), tibble formatting is dropped unless you load the tibble (or tidyverse) package because tibble is not imported in the package. This PR fixes this by importing tibble ensuring that the adam datasets print correctly, even without loading tibble/tidyverse first.

Checklist
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build pharmaverseadam site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new datasets occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@manciniedoardo
Copy link
Collaborator

Hi @MikeJohnPage - thanks for the PR! We can definitely look to update this. For completeness could you please:

  • Make a corresponding issue for this PR as we track all updates through issues
  • Add a line in the NEWS.md for this update, referencing that issue.

After that is done please let me know and I will be happy to review and approve.

@manciniedoardo manciniedoardo self-requested a review November 19, 2024 09:24
@MikeJohnPage
Copy link
Contributor Author

Opened issue #95

Where would you like me to place the item in NEWS.md. Do you need me to bump the version number of the package?

@manciniedoardo
Copy link
Collaborator

manciniedoardo commented Nov 20, 2024

Opened issue #95

Where would you like me to place the item in NEWS.md. Do you need me to bump the version number of the package?

We have a workflow for that, so no need. It can be placed under pharmaverseadam (development version) like we did for 1.1.0:

image

@MikeJohnPage
Copy link
Contributor Author

Okay, done 👍

@manciniedoardo
Copy link
Collaborator

Okay, done 👍

Thanks - unfortunately not quite what I was meaning sorry, I might've been unclear. I think you are missing the development version section? See the version in main right now for comparison. We should add a new "developer notes" section under the development version, with this update. You can merge main into your branch to get the latest NEWS.md as it updated after you started working on this. Thanks!

Also pls fix failing spelling check by adding "tibble" to inst/WORDLIST.

@MikeJohnPage
Copy link
Contributor Author

I've made the changes you requested 👍

Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeJohnPage LGTM 😄

@manciniedoardo manciniedoardo merged commit 68d55f6 into pharmaverse:main Nov 25, 2024
16 checks passed
@manciniedoardo manciniedoardo linked an issue Nov 25, 2024 that may be closed by this pull request
@manciniedoardo manciniedoardo changed the title Import tibble for printing Closes #95: Import tibble for printing Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default tibble formatting is not printed
2 participants