tag some tests with ignoreNotImplementedSelectors: #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand. The versions of the methods that I see in your commits are not the good ones (for Pharo-11, Pharo12 and master) |
|
Ah, no you're right! We cleaned and renamed a lot of shitty methods helperMethodXXX and apparently forgot to replace this one. But now, I am even more confused: why is the CI green with this??? |
|
It was due to this PR: https://github.com/pharo-spec/ScriptableDebugger/pull/60/files#diff-76f88c683f6eb63beac68142c9836853e4fdd9446be138f7a971000094b46548 Each call to |
|
And the call to |
|
Alternative: #81 |
|
This is just code quality. No need to backport this. P12 is enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is backward compatible to Pharo11 (just ignored there)