refactor: clean up slack notifcation for signups#817
Open
rohan-chaturvedi wants to merge 2 commits intomainfrom
Open
refactor: clean up slack notifcation for signups#817rohan-chaturvedi wants to merge 2 commits intomainfrom
rohan-chaturvedi wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notify_slack()was called inside each OAuth adapter'scomplete_login(), which runs before allauth creates theCustomUser. If the request failed after the notification but before user creation was committed, the user would retry and trigger another notification since the user still didn't exist.user_signed_upsignal, which fires only once, after the user is confirmed created in the database.Changes
backend/api/signals.pywith auser_signed_upsignal handler for Slack notificationsbackend/api/config.py(APIConfig.ready())notify_slackcalls and related imports from all three OAuth adapters (Google, GitHub, GitLab)Test plan