Fix fontawesome4 less and some imperfection of #1119#1212
Open
ttskch wants to merge 2 commits intophiamo:masterfrom
Open
Fix fontawesome4 less and some imperfection of #1119#1212ttskch wants to merge 2 commits intophiamo:masterfrom
ttskch wants to merge 2 commits intophiamo:masterfrom
Conversation
added 2 commits
March 6, 2017 10:46
…tead of non-existent spinning.less
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already merged PR #1119 is not perfect in following points.
font-awesome4directory,spinning.lessis deleted butfont-awesome.lessstill depends onspinning.less.font-awesomedirectory,font-awesome.lessno longer depends onspinning.lessbutspinning.lessfile still exists.This PR fixes these. Thanks.