Skip to content

Commit

Permalink
chore: fix pytest warning
Browse files Browse the repository at this point in the history
  • Loading branch information
phil65 committed Nov 27, 2024
1 parent 792cfdf commit 3d4a990
Showing 1 changed file with 29 additions and 29 deletions.
58 changes: 29 additions & 29 deletions tests/test_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,34 @@


# Simple test registry
class TestItem:
class RegItem:
"""Test item for registry."""

def __init__(self, value: str):
self.value = value


class TestRegistry(BaseRegistry[str, TestItem]):
class Registry(BaseRegistry[str, RegItem]):
"""Test registry implementation."""

@property
def _error_class(self) -> type[exceptions.LLMLingError]:
return exceptions.LLMLingError

def _validate_item(self, item: Any) -> TestItem:
if isinstance(item, TestItem):
def _validate_item(self, item: Any) -> RegItem:
if isinstance(item, RegItem):
return item
if isinstance(item, str):
return TestItem(item)
return RegItem(item)
msg = f"Invalid item type: {type(item)}"
raise self._error_class(msg)


# Tests
def test_registry_observer_registration():
"""Test that observers can be registered and unregistered."""
registry = TestRegistry()
events = RegistryEvents[str, TestItem]()
registry = Registry()
events = RegistryEvents[str, RegItem]()

# Register
registry.add_observer(events)
Expand All @@ -50,13 +50,13 @@ def test_registry_observer_registration():

def test_item_added_event():
"""Test that item addition triggers event."""
registry = TestRegistry()
events = RegistryEvents[str, TestItem]()
registry = Registry()
events = RegistryEvents[str, RegItem]()

# Track calls
called_with = None

def on_added(key: str, item: TestItem) -> None:
def on_added(key: str, item: RegItem) -> None:
nonlocal called_with
called_with = (key, item)

Expand All @@ -65,7 +65,7 @@ def on_added(key: str, item: TestItem) -> None:
registry.add_observer(events)

# Add item
test_item = TestItem("test")
test_item = RegItem("test")
registry.register("test", test_item)

# Check event was triggered
Expand All @@ -77,13 +77,13 @@ def on_added(key: str, item: TestItem) -> None:

def test_item_modified_event():
"""Test that item modification triggers event."""
registry = TestRegistry()
events = RegistryEvents[str, TestItem]()
registry = Registry()
events = RegistryEvents[str, RegItem]()

# Track calls
called_with = None

def on_modified(key: str, item: TestItem) -> None:
def on_modified(key: str, item: RegItem) -> None:
nonlocal called_with
called_with = (key, item)

Expand All @@ -92,8 +92,8 @@ def on_modified(key: str, item: TestItem) -> None:
registry.add_observer(events)

# Add and modify item
registry.register("test", TestItem("original"))
new_item = TestItem("modified")
registry.register("test", RegItem("original"))
new_item = RegItem("modified")
registry.register("test", new_item, replace=True)

# Check event was triggered
Expand All @@ -105,13 +105,13 @@ def on_modified(key: str, item: TestItem) -> None:

def test_item_removed_event():
"""Test that item removal triggers event."""
registry = TestRegistry()
events = RegistryEvents[str, TestItem]()
registry = Registry()
events = RegistryEvents[str, RegItem]()

# Track calls
called_with = None

def on_removed(key: str, item: TestItem) -> None:
def on_removed(key: str, item: RegItem) -> None:
nonlocal called_with
called_with = (key, item)

Expand All @@ -120,7 +120,7 @@ def on_removed(key: str, item: TestItem) -> None:
registry.add_observer(events)

# Add and remove item
test_item = TestItem("test")
test_item = RegItem("test")
registry.register("test", test_item)
del registry["test"]

Expand All @@ -133,8 +133,8 @@ def on_removed(key: str, item: TestItem) -> None:

def test_reset_event():
"""Test that reset triggers event."""
registry = TestRegistry()
events = RegistryEvents[str, TestItem]()
registry = Registry()
events = RegistryEvents[str, RegItem]()

# Track calls
was_called = False
Expand All @@ -148,7 +148,7 @@ def on_reset() -> None:
registry.add_observer(events)

# Add item and reset
registry.register("test", TestItem("test"))
registry.register("test", RegItem("test"))
registry.reset()

# Check event was triggered
Expand All @@ -157,17 +157,17 @@ def on_reset() -> None:

def test_multiple_observers():
"""Test that multiple observers receive events."""
registry = TestRegistry()
events1 = RegistryEvents[str, TestItem]()
events2 = RegistryEvents[str, TestItem]()
registry = Registry()
events1 = RegistryEvents[str, RegItem]()
events2 = RegistryEvents[str, RegItem]()

# Track calls
calls = []

def on_added1(key: str, item: TestItem) -> None:
def on_added1(key: str, item: RegItem) -> None:
calls.append(1)

def on_added2(key: str, item: TestItem) -> None:
def on_added2(key: str, item: RegItem) -> None:
calls.append(2)

# Set up observers
Expand All @@ -177,7 +177,7 @@ def on_added2(key: str, item: TestItem) -> None:
registry.add_observer(events2)

# Add item
registry.register("test", TestItem("test"))
registry.register("test", RegItem("test"))

# Check both observers were called
assert len(calls) == 2 # noqa: PLR2004
Expand Down

0 comments on commit 3d4a990

Please sign in to comment.